[Bug 207853] Review Request: tclabc - A Tcl interface and a Tk GUI to the ABC notation

bugzilla at redhat.com bugzilla at redhat.com
Thu Sep 28 15:51:22 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tclabc - A Tcl interface and a Tk GUI to the ABC notation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207853





------- Additional Comments From gemi at bluewin.ch  2006-09-28 11:51 EST -------
(In reply to comment #9)
> Well, Reviewing this.
> 
> 1. From http://fedoraproject.org/wiki/Packaging/Guidelines :
> 
> * Requires and BuildRequires
>   - The following Requires/BuildRequires are not needed.
>     * BuildRequires: tcl <- required by tk
>     * BuildRequires: tk <- required by tk-devel
>     * BuildRequires: tcl-devel <- required by tk-devel
>     * Requires: tcl <- required by tk
Ok.

>     Check the BuildRequires dependency for alsa library.
Ok.

>     * At least the encoding of /usr/share/doc/tclabc-1.0.7/README
>       should be changed to UTF-8.
>     * Also check if other tcl files can also have their encodings changed
>       to UTF-8.
Ok.

> * Timestamps
>   - This package includes some html files in source files, so keeping
>     timestamps for these html files are recommended.
This I don't understand. Why is it necessary?

> 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
> 
> * The sources used to build the package...
>   Use: http://moinejf.free.fr/tclabc-%{version}.tar.gz
>   for Source0
I see nothing in the guidelines about this, but ok.

> 3. Other things I have noticed.
> * Well, I don't understand how to use this, however, when I try
>   "tkabc bachto.mid" (bachto.mid is MIDI file), I get:
> 
> [tasaka1 at localhost TEMP]$ tkabc bachto.mid 
> no output MIDI synth
> open: No such file or directory
> cannot open MIDI in '/dev/midi00'
The MIDI devices have to be configured in the preferences dialog.
When alsa is used, something like "17:0" has to be used for an
alsa midi devices. However this depends on the soundcard.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list