[Bug 223657] Review Request: PerceptualDiff - An image comparison utility

bugzilla at redhat.com bugzilla at redhat.com
Thu Apr 12 15:14:40 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PerceptualDiff - An image comparison utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223657





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-04-12 11:14 EST -------

Well, for 1.0.1-1:
* cmake special issue
  - Please make the build process _VERBOSE_ . Currently
    only the messages like
-----------------------------------------
[ 20%] Building CXX object CMakeFiles/perceptualdiff.dir/PerceptualDiff.o
-----------------------------------------
    are shown and I cannot check if the compilation is
    done properly (however, for 1.0.1-1 I can say that the
    compilation process is wrong because mockbuild log says:
-----------------------------------------
extracting debug info from
/var/tmp/PerceptualDiff-1.0.1-1.fc7-root-mockbuild/usr/bin/perceptualdiff
0 blocks
-----------------------------------------
    You can check:
    http://fedoraproject.org/wiki/PackagingDrafts/cmake
    Here you cannot use /etc/rpm/macros.cmake but you can borrow
    some trick from that page.

* macro
  - Please use macro (%{_sysconfdir}, %{_prefix}, ...)

* rpath
  - Well, for me chrpath seems unneeded as actually the created Makefile
    does not set rpath, you can refer to the URL above also for
    handling rpath.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list