[Bug 226134] Merge Review: mdadm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mdadm


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226134





------- Additional Comments From wolfy at nobugconsulting.ro  2007-04-12 12:12 EST -------
rpmlint checks:

[wolfy at wolfy64 mdadm]$ rpmlint mdadm-2.6.1-3.fc7.src.rpm
W: mdadm summary-not-capitalized mdadm controls Linux md devices (software RAID
arrays)
-> ignorable
W: mdadm strange-permission mdmonitor.init 0755
-> including the file as 644 and setting it via install -p at 0755 would
probably make rpmlint happier. not a big deal anyway
W: mdadm unversioned-explicit-obsoletes mdctl
W: mdadm unversioned-explicit-obsoletes raidtools
-> As far as I have understood, these tools are gone for good, so this could be OK
  If very very sure that none of these will ever come back, it's OK, but most
probably a versioning measure should be put in place
W: mdadm mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 7)
-> cosmetic, please fix before uploading to CVS

[wolfy at wolfy64 mdadm]$ rpmlint mdadm-2.6.1-3.fc7.x86_64.rpm
W: mdadm summary-not-capitalized mdadm controls Linux md devices (software RAID
arrays)
->ignorable
E: mdadm obsolete-not-provided mdctl
E: mdadm obsolete-not-provided raidtools
-> see above
E: mdadm non-standard-dir-perm /var/run/mdadm 0700
-> security measure?
W: mdadm service-default-enabled /etc/rc.d/init.d/mdmonitor
-> ignorable per comment #2
W: mdadm incoherent-init-script-name mdmonitor
-> given my mdadm/mdmonitor change. ignorable

GOOD

- package meets naming guidelines
- package meets packaging guidelines [*]
- license (GPL ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream, sha1sum
c0f523853a9c816986c24c699fa80b2c02336f3d  mdadm/devel/mdadm-2.6.1.tgz
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of foreign
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for separate package for docs
- nothing in %doc affects runtime
- not a GUI, so no need for .desktop file 
- no .pc, .la files
- sciptlets are sane, including removal of previously existing but no longer
needed mdmpd
- final provides are sane:
[wolfy at wolfy64]$ rpm -q --provides mdadm
mdadm = 2.6.1-3.fc7
- final requires are mostly sane:
[wolfy at wolfy64]$ rpm -q --requires mdadm|sort -u
/bin/bash
/bin/sh
libc.so.6()(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3.3)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.3)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rtld(GNU_HASH)
/sbin/chkconfig
/sbin/service
smtpdaemon

[*] There is one static compiled binary but it is needed so this should be
considered an exception to normal policy of a separate -static package.


SHOULD
- builds in mock/devel/x86_64
- works as advertised

Recommended fixes:
a) timestamp is not preserved for /usr/share/doc/mdadm-2.6.1/mdadm.conf-example:
-rw-r--r--    1 root    root             2180 Apr 11 19:16 
one can see that this is the build time, not the file time in the tar (
-rw-r--r-- 1 wolfy wolfy  2194 Jun 20  2006)
The difference comes from mdadm-1.5.0-email.patch; I suggest "touch -r" using
one of the other doc files as reference

b) %defattr(-,root,root,-) instead of %defattr(-,root,root)


Only remaining issue is the "smtpdaemon" Requires which definitely should be
replaced either by the virtual provide MTA or (better yet) by "/usr/sbin/sendmail"

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.