[Bug 225718] Merge Review: eel2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: eel2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225718


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium

dakingun at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |dakingun at gmail.com
               Flag|                            |fedora-review?




------- Additional Comments From dakingun at gmail.com  2007-04-14 12:26 EST -------
GOOD:
* Package name conforms to the Fedora Naming Guidelines
* Group and License tags properly in place
* Locales handled correctly
* All necessary BuildRequires listed.
* Package builds OK in Mock.
* Source matches upstream
md5sum: dd06a56773af79e4292e63c6bcca9449  eel-2.18.0.1.tar.bz2

NEEDSWORK:
* Source url not given in the spec
* eel2-devel should not own %{_libdir}/pkgconfig, the -devel %files section
should have /usr/lib/pkgconfig/eel-2.0.pc instead
* rpmlint warnings:
$ rpmlint eel2-2.18.0.1-3.fc7.src.rpm
W: eel2 mixed-use-of-spaces-and-tabs (spaces: line 17, tab: line 16)
$ rpmlint eel2-2.18.0.1-3.fc7.x86_64.rpm
W: eel2 spurious-executable-perm /usr/share/doc/eel2-2.18.0.1/COPYING
$ rpmlint eel2-devel-2.18.0.1-3.fc7.x86_64.rpm
W: eel2-devel no-documentation   (can be ignored!)

Minor nit:
$RPM_OPT_FLAGS already includes a '-g' option



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.