[Bug 236486] Review Request: Profugus - automatically migrates Xen virtual machines from one system to another based on CPU time

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Profugus - automatically migrates Xen virtual machines from one system to another based on CPU time


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236486





------- Additional Comments From wolfy at nobugconsulting.ro  2007-04-14 21:36 EST -------
Here are a couple of errors I have spotted at the first glance
- BuildRoot is wrong, please see
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473
- you should use "cp -p" or better yet "install -p" in order to preserve the
timestamps of the files
- you should not use "ln -s " in order to install the start/stop script; instead
you should just install the script in it's final location (/etc/init.d) and
allow the admins to use chkconfig to activate/deactivate it; please also make
sure that it is not enabled by default. Given the current shape of the
"profugus" file, it looks like it needs a couple of lines to make it chkconfig-aware
- you should include in the package the text of the license used for the program
(GPL) and also include it as %doc in the binary rpm

Please provide direct links to the spec and src.rpm if possible, not the general
link to the project page.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.