[Bug 170303] Review Request: google-perftools: Very fast malloc & performance analysis tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: google-perftools: Very fast malloc & performance analysis tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170303





------- Additional Comments From tcallawa at redhat.com  2007-04-24 10:57 EST -------
(In reply to comment #35)
> I'm still here... ;)
> 
> All checks are OK under FC5 i386 !
> 
> 
> Questions:
> 
> It seems that libunwind is not strongly required.

It is on x86_64, and since it doesn't hurt us to have it everywhere, I made it a
generic BuildRequires.

> I've successfully built google-perftools under FC5/i386 without it at all. Since
> there is no libunwind in FC5 and FC6 distros, and since the trying to build it
> under FC5/i386 was failed (due to failed checks), maybe drop this BR, or at
> least use this BR for particular arch (64) only?

More likely, I'll just remove that BR for FC-5/6 and mark it i386 only for those
dists.

> Patching of both Makefile.am and Makefile.in files looks like not very good way,
> AFAIK in such a case we should patch *.am and run some autotools to update *.in 

Ehh... I'm trying to avoid dragging in autotools. I patched both the .am and the
.in so that it would be clean to anyone who did run autotools off the source.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.