[Bug 225783] Merge Review: gdb

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gdb


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225783





------- Additional Comments From skasal at redhat.com  2007-04-25 05:39 EST -------
rpmlint v. 0.80 is not silent on gdb src.rpm.
(rpmlint on the binary rpm is OK.)

Jan, your advice is needed for the not-applied-patch issue.
The rest are just a formal issues; is it OK with you if I fix them?

W: gdb patch-not-applied Patch197: gdb-6.5-bz198365-IPv6.patch
A patch is included in your package but was not applied.

W: gdb summary-ended-with-dot A GNU source-level debugger for C, C++, Java and
other languages.
Summary ends with a dot.

W: gdb unversioned-explicit-obsoletes gdb64
The specfile contains an unversioned Obsoletes: token, which will match all
older, equal and newer versions of the obsoleted thing.  This may cause update
problems, restrict future package/provides naming, and may match something it
was originally not inteded to match -- make the Obsoletes versioned if
possible.

E: gdb hardcoded-library-path in /usr/lib/libc.so
A library path is hardcoded to one of the following paths: /lib,
/usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}.

W: gdb macro-in-%changelog check
W: gdb macro-in-%changelog p
Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally
odd entries eg. in source rpms, which is rarely wanted.  Avoid use of macros
in %changelog altogether, or use two '%'s to escape them, like '%%foo'.

W: gdb mixed-use-of-spaces-and-tabs (spaces: line 530, tab: line 517)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.