[Bug 231675] Review Request: librra - Connection to Pocket PC devices, part of SynCE
bugzilla at redhat.com
bugzilla at redhat.com
Fri Apr 27 09:19:38 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: librra - Connection to Pocket PC devices, part of SynCE
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231675
bugzilla at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |medium
Priority|normal |medium
andreas.bierfert at lowlatency.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From andreas.bierfert at lowlatency.de 2007-04-27 05:19 EST -------
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
* OK: rpmlint is silent
* OK: package is named according to the guidelines
* OK: spec file name matches base package name
* OK: package meets packaging guidelines
* OK: license
* OK: license field matches actual license
* OK: license is not included as own file and thus is not included in %doc
* OK: Spec file seems to be in AE
* OK: no obfuscated code spec
* OK: sources match upstream:
72742f93f19d5727159989ec80a725f0 synce-rra-0.9.1.tar.gz
72742f93f19d5727159989ec80a725f0
/homes/awjb/rpmbuild/SOURCES/synce-rra-0.9.1.tar.gz
* OK: Builds fine on x86_64/fc6
* OK: BR seem fine
* OK: package has no locale support
* OK: ldconfig is run
* OK: package is not explicitly designed to be relocatable
* OK: package owns %{_includedir}/rra
* OK: no duplicate files in file listing
* OK: %defattr and permissions seem ok
* OK: %clean section is present
* OK: macros are used consistently
* OK: content is ok
* OK: no doc package needed
* OK: %doc files do not affect runtime
* OK: header files are in -devel
* OK: no static lib
* OK: pkgconfig is not needed
* OK: no .so file
* OK: -devel requires main package
* OK: package does not contain .la archives
* OK: no .desktop needed
* OK: does not own files/directories from other packages
* OK: buildroot is rm at beginning of install
* OK: filenames seem to be valid utf8
Package d9d02a54ebbab717ec4ec0fa55aa9405 librra-0.9.1-1.src.rpm
is APPROVED with the following patch:
- --- librra.spec.1 2007-03-09 22:58:01.000000000 +0100
+++ librra.spec 2007-04-27 11:13:08.000000000 +0200
@@ -11,6 +11,7 @@
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRequires: libsynce-devel, librapi-devel, libmimedir-devel
+BuildRequires: libtool
# Provide an upgrade path from the monilithic synce package
Provides: synce = %{version}-%{release}
@@ -35,14 +36,14 @@
%build
%configure --disable-static --disable-rpath
- -make %{?_smp_mflags}
+make LIBTOOL=%{_bindir}/libtool %{?_smp_mflags}
%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT
- -rm -f $RPM_BUILD_ROOT%{_libdir}/*.la
+rm -f $RPM_BUILD_ROOT%{_libdir}/*.{la,a}
%clean
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
iD8DBQFGMb/JQEQyPsWM8csRApGNAKCm5tpg0LrxBKoAud3PQH4/Sfef/gCfdsWV
2VBWLC3r5yvtiFQJQXKXmGo=
=gIso
-----END PGP SIGNATURE-----
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list