[Bug 235191] Review Request: postr - Flickr uploader

bugzilla at redhat.com bugzilla at redhat.com
Sun Apr 29 09:09:19 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postr - Flickr uploader


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235191





------- Additional Comments From trond.danielsen at gmail.com  2007-04-29 05:09 EST -------
(In reply to comment #5)
> Whoa!
> 
> the md5sum from the postr-0.5.tar.gz you include in your srpm doesn't match the
> one pulled from  http://burtonini.com/computing/postr-0.5.tar.gz.
> 
> I did a quick diff of the contents, there is a difference, upstream did a quick
> fix to setup.py which the tarball you are using doesn't include.
> 
> diff -u postr-0.5/setup.py /tmp/postr-0.5/setup.py 
> --- postr-0.5/setup.py  2007-02-09 08:22:14.000000000 -0900
> +++ /tmp/postr-0.5/setup.py     2007-04-03 23:08:51.000000000 -0800
> @@ -3,7 +3,7 @@
>  from distutils.core import setup
>  
>  setup(name='Postr',
> -      version='0.4',
> +      version='0.5',
>        description='Flickr Uploader',
>        author='Ross Burton',
>        author_email='ross at burtonini.com',
> 
> Please update your source tarball and do a srpm release bump. Might as well
> include that upstream icon as a new source while your at it.
> 
> -jef

Thanks for pointing out all the issues. The version number was wrong in setup.py
earlier, but I did not notice that a new tarball was released. I'll create a new
version tonight, with the icons from bzr included.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list