[Bug 249235] Review Request: pidgin-knotify - KNotify plugin for Pidgin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pidgin-knotify - KNotify plugin for Pidgin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249235





------- Additional Comments From kevin at tummy.com  2007-08-05 20:28 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License(LGPLv2)
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
00c9a07cbe529e1375d2dc5ad7a3b1fb  knotify-plugin_0.1.tar.gz
00c9a07cbe529e1375d2dc5ad7a3b1fb  knotify-plugin_0.1.tar.gz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
Ok - Package has a correct %clean section.
Ok - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
See below - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version

Issues:

1. You might make the summary a bit less harsh, perhaps just remove        
the second sentence, or just change it to "This is for KDE pidgin users".
Not a blocker, just a comment.

2. According to the new license rules the License tag here should be:
LGPLv2. You could ask upstream to include a copy in the package.

3. In your patch, you might make the cp do a 'cp -a' to preserve timestamps
on the plugin as it was built.

4. rpmlint says:
W: pidgin-knotify no-documentation

Can ignore.

W: pidgin-knotify invalid-license LGPL
W: pidgin-knotify invalid-license LGPL
W: pidgin-knotify-debuginfo invalid-license LGPL

Should be LGPLv2.

W: pidgin-knotify mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 10)

Fix if you get a chance, not a blocker.

5. Doesn't build here on x86_64... I get:

+ make -j2
gcc -o knotify-plugin.so -shared knotify-plugin.c `pkg-config pidgin --cflags
--libs` -g -Wall
/usr/bin/ld: /tmp/ccfkilnZ.o: relocation R_X86_64_32 against `a local symbol'
can not be used when making a shared object; recompile with -fPIC
/tmp/ccfkilnZ.o: could not read symbols: Bad value
collect2: ld returned 1 exit status
make: *** [knotify-plugin.so] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.66121 (%build)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.