[Bug 248301] Review Request: lzma - lzma compression tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lzma - lzma compression tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248301





------- Additional Comments From patrice.bouchand.fedora at gmail.com  2007-08-07 05:47 EST -------

> * If -devel subpackage is licensed under LGPL, the corresponding
>   documents should be installed as a %doc of -devel subpackage
>   (i.e. add LICENSE.LIB to %doc of -devel subpackage).

COPYING.LIB has been added to -devel subpackage.

> * Add ChangeLog to %doc

Done.

> * Usually the dependency against main or subpackage should be
>   version-release specific.
>   i.e. main package should have:
>   Requires: %{name}-libs = %{version}-%{release}

Main package seems to not require -libs to work.

>   and -devel package should have:
>   Requires: %{name} = %{version}-%{release}

-devel does not require main package to work, but if I remove it rpmlint complains ?

> * Provides: %{name}-devel = ... on -devel subpackage is not needed

This has been removed.

> * Explain why -devel package *must* have 
>   Provides: lzmadec-devel = %{version}-%{release}
>   (I suggest to remove this)

The devel package only provides a way to decompress lzma archive, not to
compress. As you suggest, I remove it. Should lzma-libs become lzmadec-libs ? (
and lzma-devel -> lzmadec-devel )

> * Please use the following to keep timestamps on header files
>   and man pages.
> ----------------------------------------------------
> make install DESTDIR=%{buildroot} INSTALL="%{_install} -p"
> -----------------------------------------------------

Done, but I have to use __install instead of _install ?

> * We now recommend %defattr(-,root,root,-)

Done.

> * and %defattr(0644,root,root,-755) on -devel package is not needed.

Done.

> * You define %{src_version} and it seems that it can be
>   used also for source tarball name.

Done.

> * Files under %{_mandir} is automatically tagged as %doc

%doc has been removed for %{_mandir}

The new files:

Spec URL: http://patrice.bouchand.free.fr/rpm/lzma.spec
SRPM URL: http://patrice.bouchand.free.fr/rpm/lzma-4.32.0-0.5.beta3.fc7.src.rpm

   Thanks for your time.

        Patrice



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.