[Bug 251317] Review Request: pinot - Personal search and metasearch for the Desktop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pinot - Personal search and metasearch for the Desktop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251317


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-08-13 10:32 EST -------
Okay

One comment and one rpmlint

* desktop-file-install
--------------------------------------------------------
desktop-file-install --vendor fedora       \
  --dir $RPM_BUILD_ROOT%{_datadir}/applications \
$RPM_BUILD_ROOT%{_datadir}/applications/pinot.desktop
rm -f $RPM_BUILD_ROOT%{_datadir}/applications/pinot.desktop
--------------------------------------------------------
  - This can be done by one line:
--------------------------------------------------------
desktop-file-install --vendor fedora       \
  --dir $RPM_BUILD_ROOT%{_datadir}/applications \
  --delete-original \
  $RPM_BUILD_ROOT%{_datadir}/applications/pinot.desktop
--------------------------------------------------------

* rpmlint
--------------------------------------------------------
W: pinot macro-in-%changelog files
--------------------------------------------------------
  - In changelog, use %% (i.e. Fix %%files section)
    to avoid that % macro is expanded.

Please fix the issues above before committing into Fedora CVS.
---------------------------------------------------------
      This package (pinot) is APPROVED by me
---------------------------------------------------------


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.