[Bug 252104] Review Request: perl-Perlbal-XS-HTTPHeaders - Perlbal extension for processing HTTP headers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Perlbal-XS-HTTPHeaders - Perlbal extension for processing HTTP headers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=252104


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-08-17 04:43 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
d011eeda6adedf069620e11e6d701b77  Perlbal-XS-HTTPHeaders-0.19.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/HTTPHeaders....ok
All tests successful.
Files=1, Tests=31,  0 wallclock secs ( 0.19 cusr +  0.02 csys =  0.21 CPU)
+ exit 0
+ Provides: HTTPHeaders.so perl(Perlbal::XS::HTTPHeaders) = 0.19
+ Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libgcc_s.so.1
libgcc_s.so.1(GCC_3.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(GLIBCXX_3.4) perl >= 0:5.008 perl(:MODULE_COMPAT_5.8.8)
perl(AutoLoader) perl(Carp) perl(Exporter) perl(Perlbal)
perl(Perlbal::HTTPHeaders) perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.