[Bug 250040] Review Request: new - A simple template system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: new - A simple template system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250040





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-08-18 11:06 EST -------
For -2:

* rpmlint
  - rpmlint (for rpms) complaints about:
--------------------------------------------------
E: new non-executable-script /usr/share/new/templates/missing/default 0644
E: new non-executable-script /usr/share/new/templates/py/default 0644
E: new non-executable-script /usr/share/new/templates/sh/default 0644
W: new invalid-license GPL
W: new invalid-license GPL
W: new setup-not-quiet
W: new macro-in-%changelog files
W: new macro-in-%changelog doc
W: new mixed-use-of-spaces-and-tabs (spaces: line 22, tab: line 112)
W: new-debuginfo invalid-license GPL
W: new-devel no-documentation
W: new-devel invalid-license GPL
W: new-java no-documentation
E: new-java library-without-ldconfig-postin /usr/lib/libnewfmt_ptrnjni.so.1.3.9
E: new-java library-without-ldconfig-postun /usr/lib/libnewfmt_ptrnjni.so.1.3.9
E: new-java library-without-ldconfig-postin /usr/lib/libnewfmt_ptrnjava.so.1.3.9
E: new-java library-without-ldconfig-postun /usr/lib/libnewfmt_ptrnjava.so.1.3.9
W: new-java invalid-license GPL
------------------------------------------------------
   * Summary
     - Some scripts have shebangs but don't have executable permission.
       * If the scripts are to be executed by users directly, then
         the scripts should have executable permission
       * If they are to be called by other programs and are not to be
         executed directory, then shebangs should be removed.
     - Update License tag according to:
       http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
       http://fedoraproject.org/wiki/Licensing
     - Supress verbose messages on %setup. i.e. use
       %setup -q
     - In the %changelog, please use %% (i.e. %%files, %%doc)
       to prevent macros from being expanded.
     - For identation, please use spaces OR tabs, not both.
     - Call ldconfig for libnewfmt_ptrnjni.so and so on (and
       check the section "dependency between main <-> subpackages"
       written below)

* parallel make support:
  - Rebuild failed on ppc (-j8)
    http://koji.fedoraproject.org/koji/taskinfo?taskID=108280
    When I disabled parallel make support, it seems okay
    http://koji.fedoraproject.org/koji/taskinfo?taskID=108298

    So, please either
    * temporally disable parallel make support
    * or fix to support parallel make correctly

* Unneeded dependency
----------------------------------------------------
Requires: zlib
----------------------------------------------------
  - This must be removed. rpmbuild checks and adds the dependency
    of libraries automatically and the dependency against libz.so
    should automatically pulls zlib.

* %makeinstall
  - Please don't use %makeinstall unless this is surely
    needed
    (check the section "Why the %makeinstall macro should not be used"
     of http://fedoraproject.org/wiki/Packaging/Guidelines )

* defattr
  - Now we recommand %defattr(-,root,root,-)

* dependency between main <-> subpackages
----------------------------------------------------
[tasaka1 at localhost new]$ rpm -qp --requires new-1.3.9-2.fc8.1.i386.rpm | grep libnew
libnewfmt_ptrn.so.1  
libnewfmt_ptrnjava.so.1  
libnewfmt_ptrnjni.so.1  
libnewtemplate.so.1  
[tasaka1 at localhost new]$ rpm -qp --provides new-1.3.9-2.fc8.1.i386.rpm | grep libnew
libnewfmt_ptrn.so.1  
libnewtemplate.so.1  
----------------------------------------------------
  - This is undesirable. This shows that new main package
    require libnewfmt_ptrnjava.so, but it is not provided by
    itself and so main package requires -java subpackage.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.