[Bug 250210] Review Request: gimp-resynthesizer - Gimp plugin for texture synthesis

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gimp-resynthesizer - Gimp plugin for texture synthesis


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250210


lxtnow at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |lxtnow at gmail.com




------- Additional Comments From lxtnow at gmail.com  2007-08-18 17:41 EST -------
Well,

# Top comment is unnecessary, summary tag is enough.

# license tag need to be fix, as the license policy has been changed, you need
to set explicitly the version of the licensed package now.
So, set it to GPLv2 as your package is.

# Yous should use the recommanded default buildroot which is:
  BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

# RPM variable style VS RPM macros style:
You should use one of them, not mixe them in spec.
Also there are duplicate command is the spec, should be fix.

# Package doesn't honor RPM_OPT_FLAGS

# Failed to build on mock F-devel
-------------------------------------------------------------------------------
[...]
g++ `gimptool --cflags` -O3 -Wall -fno-common -ffast-math -frename-registers
-fomit-frame-pointer -o resynth resynth.cc `gimptool --libs` -lm
resynth.cc:83: error: template with C linkage
resynth.cc:979: error: expected `}' at end of input
make: *** [resynth] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.33961 (%build)
-------------------------------------------------------------------------------



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.