[Bug 253649] Review Request: vinagre - VNC client for the GNOME desktop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vinagre - VNC client for the GNOME desktop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253649





------- Additional Comments From bnocera at redhat.com  2007-08-21 11:23 EST -------
(In reply to comment #1)
> When building in mock I get:
> 
> 
> checking for XML::Parser... configure: error: XML::Parser perl module is
> required for intltool
> 
> I've seen that problem before although I don't remember the details.  Is it that
> the packaged intltool requires XML::Parser?  I'm guessing either BuildRequires
> the parser or BuildRequires intltool and re-intltoolize will fix it.

added perl-XML-Parser as a BR

> Overall looks very good.  Minor nits that don't matter:
> 
> - rm -rf $RPM_BUILD_ROOT/%{_datadir}/doc/vinagre/  has an extra / in it (between
> ROOT and %{_datadir}

Fixed.

> - what docs are in the above anyway?  omf files? Are they worth shipping?

No, they're the usual AUTHORS, README, etc., but the maintainer thought it was
good to install them by himself. I'm removing those, and installing in the usual
versioned docs dir in %files

> - vendor isn't required anymore for desktop-file-install, just ditch it.

Done.

> - There are a handful or so Application categories, normally when tossing the
> Application category, you pick one of them to replace it with (Maybe use Network?)

It's already in Network, so appears in the same menu as TSClient

> - you have %{_datadir}/%{name}/* in the file list but the package should
> probably own the %{_datadir}/%{name} dir too.

Fixed, we want the whole dir.

Spec URL: http://people.redhat.com/bnocera/vinagre/vinagre.spec
SRPM URL: http://people.redhat.com/bnocera/vinagre/vinagre-0.2-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.