[Bug 241387] Review Request: codeina - GStreamer Codec Installation Application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: codeina - GStreamer Codec Installation Application


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241387





------- Additional Comments From bnocera at redhat.com  2007-08-21 18:43 EST -------
(In reply to comment #12)
> maybe add a %{?dist} tag?
> 
> what's the 
> BuildRequires:  gcc-c++
> followed by:
> BuildArch:      noarch
> 
> about?

You didn't see the "sigh, libtool" comment. Basically, libtool needed it, and
complained if it's not there. Not the case anymore though, thus removed.

> You use $RPM_BUILD_ROOT in some places and %{buildroot} in others, which is a
> little inconsistent

Fixed.

> mock build fails with 
> 
> Possible unintended interpolation of @INTLTOOL_ICONV in string at
> ../intltool-merge line 96
> Global symbol "@INTLTOOL_ICONV" requires explicit package name at
> ../intltool-merge line 96.
> 
> not sure what that's about

Version mismatch between the tarball intltool and the system one. Running
intltoolize fixes it.

Build properly under mock.

http://people.redhat.com/bnocera/codeina/codeina-0.10.0.1-0.20070525.170400.3.fc8.src.rpm
http://people.redhat.com/bnocera/codeina/codeina.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.