[Bug 250040] Review Request: new - A simple template system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: new - A simple template system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250040





------- Additional Comments From rc040203 at freenet.de  2007-08-21 23:59 EST -------
Some remarks:

* configure script spews out a pretty drastic warning:
checking for check - version >= 0.8.2... no
*** Could not run check test program, checking why...
*** The test program failed to compile or link. See the file config.log for
*** the exact error that occured.
configure: WARNING: Check not found; cannot run unit tests!

Dunno how serious this warning is - If it shall be taken serious, then there the
spec lacks some dependencies, if it isn't serious, then this configure script is
a bit too "loud".


* pass --disable-static to %configure,
spares wasting time on building the static libs.


Finally, something more general, you will not like:

 I find calling a package "new" to not be a "clever decision", because naming
files and directories "new" is a pretty sure way to cause conflicts and clashes
in future.

Consider your package is shipping this: /usr/include/new
Would your package be named "list", you now would clash with c++.
"new" isn't in a better position. 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.