[Bug 250240] Review Request: linkage - Lightweight bittorent client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: linkage - Lightweight bittorent client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250240


denis at poolshark.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |denis at poolshark.org
               Flag|                            |fedora-review?




------- Additional Comments From denis at poolshark.org  2007-08-23 08:08 EST -------
Hi Adel,

1. There as some unused-direct-shlib-dependency issues on liblinkage-1.so.0.0.3.

See discussions at
http://www.redhat.com/archives/fedora-maintainers/2006-June/msg00176.html
http://www.redhat.com/archives/fedora-packaging/2007-January/msg00158.html

There's a "hack" used in a number of packages already (alliance, clamav), that
simply patches the "-Wl,--as-needed" option into libtool right after configure.
That looks to me like the simplest option. 

2. The --prefix and --libdir options to configure are not necessary

3. libupnp-devel BR is not needed. The package looks for libgupnp, which appears
to be something completely different (and not in fedora as of yet).


There's also a libtorrent vs rb_libtorrent conflict that needs to be addressed
at some point, though that's outside the scope of this review.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.