[Bug 248224] Review Request: iwl4965-firmware - Firmware for Intel® PRO/Wireless 4965 A/G/N network adaptors

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: iwl4965-firmware - Firmware for Intel® PRO/Wireless 4965 A/G/N network adaptors


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248224


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-08-24 14:55 EST -------
I had a promise of some testing om #fedora-devel which I was hoping to see, but
in lieu of that, here's a full review.

The only comment I can make is that it would be good to have, in the spec, some
explanation of why there are multiple versions bundled and some statement of how
long old versions need to be kept bundled in the package.

* source files match upstream:
   6c1c870562c259af3df33756a811967e7e5ae6176e5ebdfc3d74a1fdc5f86d8d  
    iwlwifi-4965-ucode-4.44.1.18.tgz
   dc48285a93577aee3a24614c089a24f9aff7e29ab92bbea505704b54aeeed6d5  
    iwlwifi-4965-ucode-4.44.17.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* build root is OK.
* license field matches the actual license.
* license is acceptable for firmware in Fedora.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane; provides itself and requires nothing.
* No automated testing possible, but several successful test reports in this 
   ticket.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* acceptable content (firmware)
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.