[Bug 254093] Review Request: rubygem-rake - Ruby based make-like utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rubygem-rake - Ruby based make-like utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=254093





------- Additional Comments From mdehaan at redhat.com  2007-08-24 16:39 EST -------
basics:

+ rpmlint clean for both src and built RPM
+ src.rpm builds fine
+ name good
+ license
+ general overview of specfile
+ docs/changelog

Ruby guidelines:

+ source good
+ requires/buildrequires good
+ provides good
+ prep and build empty
+ install to gemdir follows guidelines
+ marked noarch
+ installs fine
+ trivial test "rake" runs fine when installed

potential things to look at according to packaging doc:

- "Ruby packages must require ruby at build time with a BuildRequires: ruby, and
may indicate the minimal ruby version they need for building."

- "Each Ruby package must indicate the Ruby ABI version it depends on with a
line like Requires: ruby(abi) = 1.8"

Some of the above is implicit from gem BuildRequires/usage, though I would
imagine it can't hurt if the above information is known and set explicitly.

Let me know about the above and I'll approve this.   Everything else looks fine
according to the packaging spec.




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.