[Bug 254135] Review Request: libpanelappletmm - C++ interface for Gnome panel applets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libpanelappletmm - C++ interface for Gnome panel applets


https://bugzilla.redhat.com/show_bug.cgi?id=254135





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-08-27 14:18 EST -------
For 2.6.0-1:

* Possibly missing BuildRequires
  - From build.log:
-----------------------------------------------------
Generating code for file enums.h...
Generatsh: dot: command not found
Problems running dot: exit code=127, command='dot',
arguments='"classGtk_1_1EventBox__inherit__graph.dot" -Tpng -o
"classGtk_1_1EventBox__inherit__graph.png"'
sh: dot: command not found
------------------------------------------------------
    (and similar lines follow)
    Perhaps graphviz is missing from BuildRequires
    (also graphviz-gd or so MAY be needed for BuildRequries).

* %install
------------------------------------------------------
%install
make install DESTDIR=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name "*.la" -exec rm -f {} ';'

mkdir -p $RPM_BUILD_ROOT%{_datadir}/
------------------------------------------------------
  - What is the last line for?

* Timestamps
  - This file installs some text files (such as header files)
    and keeping timestamps on them is preferable.
    For recent Makefile, the following method usually
    works (and also for this package)
------------------------------------------------------
make install DESTDIR=foo INSTALL="%{_install} -p"
------------------------------------------------------

? %_dist tag
  - Just a question, however do you dislike to use %_dist
    tag?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.