[Bug 405221] Review Request: kdebase3 - K Desktop Environment - core files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdebase3 - K Desktop Environment - core files


https://bugzilla.redhat.com/show_bug.cgi?id=405221


kevin at tigcc.ticalc.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From kevin at tigcc.ticalc.org  2007-11-30 23:49 EST -------
MUST Items:
+ rpmlint output: warnings indicating actual problems already fixed, see above
+ named and versioned according to the Package Naming Guidelines
+ spec file name matches base package name
+ Packaging Guidelines:
  + License GPLv2 OK, matches actual license
  + No known patent problems
  + No emulator, no firmware, no binary-only or prebuilt components
  + Complies with the FHS
  + proper changelog, tags, BuildRoot, Requires, BuildRequires
  ! Summary, Description need updating for kdebase3
  + no non-UTF-8 characters
  + relevant documentation included
  + RPM_OPT_FLAGS are used (%configure macro)
  + debuginfo package is valid
  + no static libraries
  + no .la files except the plugins which are needed in KDE 3 (hooray for KDE 4 
fixing this, but kdebase3 still needs them)
  + no duplicated system libraries
  + no rpaths, at least on i386
  + giving the config files in /usr a pass, as KDE has always 
used /usr/share/config
  + no init scripts, so init script guideline doesn't apply
  + GUI executables all have .desktop files
  ! ... but there's .desktop files for apps which aren't being shipped
  + no timestamp-clobbering file commands
  + _smp_mflags used
  + scriptlets are valid
  + not a web application, so web application guideline doesn't apply
  + no conflicts
+ complies with all the legal guidelines
+ license included as %doc
+ spec file written in American English
+ spec file is legible
+ source matches upstream:
  MD5SUM: 9990c669229daaaa8fca4c5e354441fd
  SHA1SUM: 07f2e33aef101e97237676719ef2bf8418d894b2
+ builds on at least one arch (F7 i386 live system)
+ no known non-working arches, so no ExcludeArch needed
+ all required BuildRequires listed (same as kdebase which built fine in Koji 
for F7/F8/F9)
+ no translations in original tarball, so translation/locale guidelines don't 
apply
+ ldconfig correctly called in %post and %postun of -libs
+ package not relocatable
+ ownership correct (owns package-specific directories, doesn't own directories 
owned by another package)
+ no duplicate files in %files
+ permissions OK
+ %clean section present and correct
+ macros used where possible
+ no non-code content
+ no large documentation files, so no -doc package needed
+ %doc files not required at runtime
+ all header files in -devel
+ no static libraries, so no -static package needed
+ no .pc files, so no Requires: pkgconfig needed
+ /usr/lib*/*.so symlinks are correctly in -devel
+ /usr/lib*/kde3/*.so plugins and /usr/lib*/kdeinit_*.so (NOT symlinks) are 
correctly NOT in -devel
+ -devel requires %{name}-libs = %{?epoch:%{epoch}:}%{version}-%{release}
+ .la files, .desktop files: see "Packaging Guidelines" section
+ buildroot is deleted at the beginning of %install
+ all filenames are valid UTF-8

SHOULD Items:
+ license already included upstream
+ no translations for description and summary provided by upstream
* Skipping mock, "all architectures" and functionality tests.
+ scriptlets are sane
+ subpackage Requires/Provides/Obsoletes are valid
+ no .pc files, so "placement of .pc files" is irrelevant
+ no exotic file dependencies
! however the dependency on /sbin/ldconfig in the main package is not needed 
if -libs is being built

No real issues, APPROVED.

(We can address the remaining nitpicks:
! Summary, Description need updating for kdebase3
! ... but there's .desktop files for apps which aren't being shipped
! however the dependency on /sbin/ldconfig in the main package is not needed 
if -libs is being built
while waiting for the CVS request to be processed or even after import.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.