[Bug 408941] Review Request: Unicornscan - Scalable, Accurate, Flexible, and Efficient Network Probing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Unicornscan - Scalable, Accurate, Flexible, and Efficient Network Probing


https://bugzilla.redhat.com/show_bug.cgi?id=408941


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wolfy at nobugconsulting.ro




------- Additional Comments From wolfy at nobugconsulting.ro  2007-12-03 13:17 EST -------
Just a quick glimpse over the spec
- Buildroot does not respect the guidelines
(http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473)
- You have duplicate Requires and Build-Requires ( for instance postgresql-devel
 requires postgresql); please also verify if all those packages listed under
Rwquires are indeed neededm usually rpm does a pretty good job with automatic deps
- You have included lots of files which probably should not be included (.a,
.la). Please see
http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7
and if the files that you have included, examine one of
-- add a comment explaining why are they needed
-- create separate packages for static and/or libtool archives


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.