[Bug 411531] Review Request: perl-Class-C3-Componentised - Load mix-ins or components to your C3-based class

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-C3-Componentised - Load mix-ins or components to your C3-based class


https://bugzilla.redhat.com/show_bug.cgi?id=411531


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-12-05 22:39 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
0e006802cff4acc319d00f4082239f9d  Class-C3-Componentised-1.0001.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'inc', 'blib/lib', 'blib/arch')" t/*.t
t/00-load.........# Testing Class::C3::Componentised 1.0001, Perl 5.008008,
/usr/bin/perl
ok
t/01-basic........ok
t/pod-coverage....ok
t/pod.............ok
All tests successful.
Files=4, Tests=6,  0 wallclock secs ( 0.25 cusr +  0.06 csys =  0.31 CPU)
+ Package perl-Class-C3-Componentised-1.0001-3.fc9 ->
  Provides: perl(Class::C3::Componentised) = 1.0001
  Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Class::C3)
perl(Class::Inspector) perl(base) perl(strict) perl(warnings)
APPROVED.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.