[Bug 402821] Review Request: phpwapmail - WAP-based e-mail client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: phpwapmail - WAP-based e-mail client


https://bugzilla.redhat.com/show_bug.cgi?id=402821





------- Additional Comments From dmitry at butskoy.name  2007-12-06 08:41 EST -------
> either spaces or tabs for indentation

It seems some kind of too extra requirement... :)  I prefer to not follow it,
because I try to create .spec files "good readable" under uncient Linux console
or even a dumb terminal. Using 4-space steps for indentation is good for this
purpose. And then I prefer to use "one tab" instead of "8 spaces" for the
"two-step" indentation... 

> non-standard-gid /etc/phpwapmail/config.php apache
> A file in this package is owned by a non standard group.

This package is intended for using under Apache and mod_php, i.e. "httpd"+"php"
Try rpmlint for the current "httpd" package. Your comments?... :)

> non-readable /etc/phpwapmail/config.php 0640

Yep, it is for security.


> sed: -e expression #1, char 34: unknown option to `s'

I cannot reproduce this... Could you obtain a full "sed" command string? (For
example, re-build the package under your environment, adding "echo" before the
"sed" command. This way the full "sed" command string will be just printed, not
executed, and we'll see whats going on...)


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.