[Bug 414721] Review Request: totem-pl-parser - the Totem Playlist Parser library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: totem-pl-parser - the Totem Playlist Parser library


https://bugzilla.redhat.com/show_bug.cgi?id=414721


bdpepple at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From bdpepple at gmail.com  2007-12-06 19:05 EST -------
Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All desired features are enabled
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
* Valid license tag

Must Fix Items:
* Needs BR on gettext & perl(XML::Parser) in order to build.  Here's a link to
my scratch build if you want to look at the build.logs:
http://koji.fedoraproject.org/koji/taskinfo?taskID=280512

Non-blockers:
* rpmlint produces the following:
totem-pl-parser.i386: W: summary-not-capitalized the Totem Playlist Parser library
totem-pl-parser.i386: W: no-url-tag
totem-pl-parser-debuginfo.i386: W: no-url-tag
totem-pl-parser-devel.i386: W: no-documentation
totem-pl-parser-devel.i386: W: no-url-tag

IMO opinion, these aren't blockers, but it might be nice to at least fix the
capitalization warning.

+1 APPROVED, just fix the BR's when you import it into CVS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.