[Bug 225611] Merge Review: bc

bugzilla at redhat.com bugzilla at redhat.com
Fri Dec 7 08:59:50 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: bc


https://bugzilla.redhat.com/show_bug.cgi?id=225611


zprikryl at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |CLOSED
         Resolution|                            |RAWHIDE
               Flag|needinfo?(zprikryl at redhat.co|
                   |m)                          |




------- Additional Comments From zprikryl at redhat.com  2007-12-07 03:59 EST -------
(In reply to comment #4)
> * Why is there an autotools call?

Because a tarball doesn't contain all needed files. For example a file depcomp
is missing. So one has to create it for successfully compilation.

> * use %{_bindir} in %files.

Fixed

> * use the "official" scriptlet for install-info and remove the .gz.
> It is just for consistency since this scriptlet is fine.

Fixed and added bc info pakges

> * remove / in  $RPM_BUILD_ROOT/%{_infodir}

Since "//" is interpreted like "/", I think that $RPM_BUILD_ROOT/%{_infodir} is
more readable than $RPM_BUILD_ROOT%{_infodir}, so I will not change it.

> * use the dist tag

Fixed


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list