[Bug 412531] Review Request: Kitsune - Mathematical game

bugzilla at redhat.com bugzilla at redhat.com
Mon Dec 10 06:05:40 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Kitsune - Mathematical game


https://bugzilla.redhat.com/show_bug.cgi?id=412531


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-12-10 01:05 EST -------
For 2.0-2

* Different spec file?
  - First of all, the spec file of 2.0-2 in your srpm and the spec
    linked from your comment 0 differ.

* Source0
  - $ wget -N
'http://kitsune.tuxfamily.org/download.php?url=kitsune2.0/kitsune-2.0.tar.gz'
    returns 404 (Not Found)
  - Instread, I cound find
    http://kitsune.tuxfamily.org/download.php?url=kitsune2.0/kitsune2.0.tar.gz
    This is redirected to
    http://download.tuxfamily.org/kitsune/kitsune2.0/kitsune2.0.tar.gz

    However:
    - The names differ
    - And the two tarballs actually differ.
------------------------------------------------------
121872 2007-11-07 21:28 kitsune-2.0-2.fc7/kitsune-2.0.tar.gz
122101 2007-05-27 23:27 kitsune2.0.tar.gz
------------------------------------------------------

* Unpacking SOURCE2
  - Please check the invokation format of %setup.
    http://docs.fedoraproject.org/drafts/rpm-guide-en/ch09s04.html
    Usually this can be replaced by
-------------------------------------------------------
%setup -q -a 2
-------------------------------------------------------

* iconv of html texts
  - When changing the encoding of html files, you also have to
    modify its contents. For example, txt/about-fr.html contains:
-------------------------------------------------------
    10    <meta content="text/html; charset=ISO-8859-1" http-equiv="content-type">
-------------------------------------------------------

* icon install
  - Would you simply the description like below?
-------------------------------------------------------
for f in 16 22 32 48 64 ; do
  mkdir -p  $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/${f}x${f}/apps
  install -p -m 0644 %{name}-icones/%{name}-${f}x${f}.png \
    $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/${f}x${f}/apps/%{name}.png
done
-------------------------------------------------------

* Directory ownership issue
-------------------------------------------------------
%files
%{_datadir}/icons/hicolor/
-------------------------------------------------------
  - This contains the directory %_datadir/icons/hicolor itself and
    all files/directories/etc under %_datadir/icons/hicolor.

    This is not proper because /usr/share/icons/hicolor, 
    /usr/share/icons/hicolor/22x22, etc are already owned by
    hicolor-icon-theme


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list