[Bug 424881] Review Request: fontmatrix - Font manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fontmatrix - Font manager


https://bugzilla.redhat.com/show_bug.cgi?id=424881





------- Additional Comments From wolfy at nobugconsulting.ro  2007-12-17 19:35 EST -------
The name seems correct to me.
However there are a few errros
- cosmetic:
  - removed work soon from description
  - remove redundand BR: gcc-c++
should be
  - removed _word_ "soon" from description
  - remove _redundant_ BR
But anyway, I would just rephrase everything to "spec cleanup".

- serious: there is a missing BR for cmake

- %build should follow the steps described at
http://fedoraproject.org/wiki/Packaging/cmake and I mean here "%cmake ." instead
of "cmake .". Your version leads to build errors in mock

- could you please let me how to verify the sources (or better said, where to
get qmake from) ? I have done a svn checkout, but I was stopped by the following
error:
[wolfy at wolfy fontmatrix]$ cmake ../fontmatrix
-- Building Fontmatrix 0.3.0svn
CMake Error: Qt qmake not found!
-- Configuring done
I have tried to locate qmake using:
  [wolfy at wolfy2 ~]$ sudo yum -c /tmp/fedora-devel-x86_64.cfg search \*qmake\*
  Setting up repositories
  Reading repository metadata in from local files
  No Matches found
but failed, as one can see above. Google suggest kdevelop, but it does not seem
to be provided by it, either.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.