[Bug 426149] Review Request: sshmenu - GNOME panel applet to organize SSH connection information in a menu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sshmenu - GNOME panel applet to organize SSH connection information in a menu


https://bugzilla.redhat.com/show_bug.cgi?id=426149


mmahut at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|                            |needinfo?(matthias at rpmforge.
                   |                            |net)




------- Additional Comments From mmahut at redhat.com  2007-12-18 15:54 EST -------
 + Package is named according to the Package Naming Guidelines.
 + Spec file name must match the base package %{name}, in the format %{name}.spec.
 + Package meets the Packaging Guidelines.
 + Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: Fedora rawhide, Fedora 8
 + Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 + Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 + License field in the package spec file matches the actual license.
     License type: BSD
 + Spec file is legible and written in American English.
 + Package is not known to require ExcludeArch
 + Package must own all directories that it creates.
 + Package does not contain duplicates in %files.
 + Permissions on files are set properly.
 + Package has a %clean section, which contains rm -rf of the buildroot
 + Package consistently uses macros.
 + File based requires are sane.
 - Rpmlint output is not sane.

    sshmenu.src:59: E: hardcoded-library-path in
%{_prefix}/lib/bonobo/servers/sshmenu-applet.server
    sshmenu.src:60: E: hardcoded-library-path in %{_prefix}/lib/ruby/*/*.rb

Not sure if this is an issue, can you check it?

I've tried it on Fedora 8 and it's working correctly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.