[Bug 408171] Review Request: perl-QWizard - A portable graphical question and answer wizard

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-QWizard - A portable graphical question and answer wizard


https://bugzilla.redhat.com/show_bug.cgi?id=408171


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-12-20 00:17 EST -------
I found the SRPM at http://www.hardakers.net/FE/perl-QWizard-3.12-2.fc8.src.rpm

Everything looks good to me.

* source files match upstream:
   f85e3f41c7752d92097b96ac6c4c502ed4e721107d6f4f6906bdd87220c06d5e
   QWizard-3.12.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(QWizard) = 3.12
   perl(QWizard::API) = 3.12
   perl(QWizard::Generator) = 3.12
   perl(QWizard::Generator::Best) = 3.12
   perl(QWizard::Generator::Gtk2)
   perl(QWizard::Generator::HTML) = 3.12
   perl(QWizard::Generator::HTML::Vertical) = 3.12
   perl(QWizard::Generator::ReadLine) = 3.12
   perl(QWizard::Generator::Tk)
   perl(QWizard::Plugins::Bookmarks) = 3.12
   perl(QWizard::Plugins::History) = 3.12
   perl(QWizard::Storage::Base) = 3.12
   perl(QWizard::Storage::CGICookie) = 3.12
   perl(QWizard::Storage::CGIParam) = 3.12
   perl(QWizard::Storage::File) = 3.12
   perl(QWizard::Storage::Memory) = 3.12
   perl(QWizard::Storage::SQL) = 3.12
   perl-QWizard = 3.12-2.fc9
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(AutoLoader)
   perl(CGI)
   perl(CGI::Cookie)
   perl(Chart::Lines)
   perl(Config)
   perl(Data::Dumper)
   perl(Exporter)
   perl(File::Temp)
   perl(Glib)
   perl(Gtk2)
   perl(IO::File)
   perl(POSIX)
   perl(QWizard)
   perl(QWizard::API)
   perl(QWizard::Generator)
   perl(QWizard::Generator::HTML)
   perl(QWizard::Storage::Base)
   perl(QWizard::Storage::CGICookie)
   perl(QWizard::Storage::CGIParam)
   perl(QWizard::Storage::File)
   perl(QWizard::Storage::Memory)
   perl(Term::ReadLine)
   perl(Tk)
   perl(Tk::FileSelect)
   perl(Tk::Pane)
   perl(Tk::Table)
   perl(strict)

* %check is present and all tests pass:
   All tests successful.
   Files=5, Tests=48,  0 wallclock secs ( 0.09 cusr +  0.03 csys =  0.12 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.