[Bug 412001] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ufoai - UFO: Alien Invasion strategy game


https://bugzilla.redhat.com/show_bug.cgi?id=412001


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|182235                      |
              nThis|                            |
         AssignedTo|mmahut at redhat.com           |j.w.r.degoede at hhs.nl




------- Additional Comments From j.w.r.degoede at hhs.nl  2007-12-21 07:44 EST -------
Marel,

Sorry for taking over your review, but I'm in the process of sponsoring Karel.

Full review done, all in all it looks good, some minor issues and your missing
some buildrequires to enable openal audiooutput and fullscreen when using the
X11 display driver:

Must Fix
--------
* Add BuildRequires: freealut-devel libXxf86vm-devel libXxf86dga-devel
* "Encoding=UTF-8" in the .desktop file is deprecated please remove it
* rpmlint:  W: file-not-utf8 /usr/share/doc/ufoai-2.1.1/CONTRIBUTORS

p.s.

Removing FE_LEGAL (and adding it to the -music subpackage)


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.