[Bug 416761] Review Request cppad - A Package for Differentiation of C++ Algorithms

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request cppad - A Package for Differentiation of C++ Algorithms


https://bugzilla.redhat.com/show_bug.cgi?id=416761





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-12-21 08:50 EST -------
* Source tarball
  - Well, I tried to download the source from the written SourceURL,
    however only I could find CppAD-2.0.1.tgz?
    (source tarball check is needed for license check)

* Build option
  - build.log says:
---------------------------------------------------------
    52  checking --with-Documentation... yes
    53  checking --with-Introduction... no
    54  checking --with-Example... yes
    55  checking --with-TestMore... yes
    56  checking --with-Speed... no
    57  checking --with-PrintFor... no
    58  checking --with-stdvector... no
---------------------------------------------------------
    You don't set some conditional configure option. Would you
    please explain why?

* Timestamps
  - As this is noarch and the installed files are only texts,
    keeping timestamps on installed files is highly preferable.

    For this package, the following keeps timestamps.
----------------------------------------------------------
%prep
%setup -q

sed -i.stamp -e 's|cp -r|cp -a|' makefile

%build
.....
%install
rm -rf $RPM_BUILD_ROOT
export CPPROG="cp -p"
make install DESTDIR=$RPM_BUILD_ROOT
.......
----------------------------------------------------------

* macros in %changelog
  - When you try "$ rpm -q --changelog cppad", you will see
----------------------------------------------------------
* Thu Dec 20 2007 Brad Bell ( bradell at seanet dot com ) 20071203-2
- Use the commands 
  CFLAGS="${CFLAGS:--O2}" ; export CFLAGS ; 
  CXXFLAGS="${CXXFLAGS:--O2}" ; export CXXFLAGS ; 
  FFLAGS="${FFLAGS:--O2}" ; export FFLAGS ; 
  for i in $(find . -name config.guess -o -name config.sub) ; do 
           [ -f /usr/lib/rpm/redhat/$(basename $i) ] && /bin/rm -f $i && /bin/cp
-fv /usr/lib/rpm/redhat/$(basename $i) $i ; 
  done ; 
.........
----------------------------------------------------------
     i.e. macros in %changelog are expanded (you can gain the warning
          about these by rpmlint).
     To avoid this, use %% in %changelog to stop macros expanding.
----------------------------------------------------------
* Wed Dec 20 2007 Brad Bell < bradell at seanet dot com > 20071203-2
- Use the commands %%configure, %%check
-----------------------------------------------------------
     BTW I recommend to use <>, not () for mail address.

* Argument list too long
  - By the way, when I try normal rpmbuild:
------------------------------------------------------------
[tasaka1 at localhost SPECS]$ LANG=C rpmbuild -bi --short-circuit cppad.spec 
Executing(%install): /bin/sh -e /home/tasaka1/rpmbuild/INSTROOT/rpm-tmp.58659
+ umask 022
+ cd /home/tasaka1/rpmbuild/BUILD
+ cd cppad-20071208
.......
cp -r ./doc/*
/home/tasaka1/rpmbuild/INSTROOT/cppad-20071208-2.fc8_p-root-tasaka1/usr/share/doc/cppad-20071208
chmod 644
/home/tasaka1/rpmbuild/INSTROOT/cppad-20071208-2.fc8_p-root-tasaka1/usr/share/doc/cppad-20071208/*

/bin/sh: /bin/chmod: Argument list too long
make[3]: *** [install-data-hook] Error 126
make[3]: Leaving directory `/home/tasaka1/rpmbuild/BUILD/cppad-20071208'
make[2]: *** [install-data-am] Error 2
make[2]: Leaving directory `/home/tasaka1/rpmbuild/BUILD/cppad-20071208'
make[1]: *** [install-am] Error 2
make[1]: Leaving directory `/home/tasaka1/rpmbuild/BUILD/cppad-20071208'
make: *** [install-recursive] Error 1
error: Bad exit status from /home/tasaka1/rpmbuild/INSTROOT/rpm-tmp.58659 (%install)
----------------------------------------------------------

* Some rpmlint
  $ rpmlint <your srpm> shows:
------------------------------------------------------------
cppad.src: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 5)
cppad.src: W: summary-ended-with-dot cppad base package (not installed).
------------------------------------------------------------
    Please fix these (you can check what these mean by
    $ rpmlint -I mixed-use-of-spaces-and-tabs , for example)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.