[Bug 400481] Review Request: trac-ticketdelete-plugin - Remove tickets and ticket changes from Trac

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: trac-ticketdelete-plugin -  Remove tickets and ticket changes from Trac


https://bugzilla.redhat.com/show_bug.cgi?id=400481


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-12-21 15:04 EST -------
You currently get r2933 when you download the source, but it seems to be the
same.  (No commits since 2006 anyway.)  You can specify the URL to use by
replacing "latest" in your URL with the SVN revision you want to check out.
Too bad spectool can't simply download that URL directly.

rpmlint says only:
  trac-ticketdelete-plugin.noarch: W: no-documentation
which is no problem.

You can probably nuke that comment in the first line and the one in the %files
section as they come from the specfile template.

Really, I see nothing blocking this package.

* source files match upstream:
   2222a50ff44005f103286747fe0e4cb99e29f78ec11693061e86e0fb497e6149
    ticketdeleteplugin-r2825.zip
   2222a50ff44005f103286747fe0e4cb99e29f78ec11693061e86e0fb497e6149
    ticketdeleteplugin-r2933.zip

* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   trac-ticketdelete-plugin = 1.1.4-1.20071126svn2825.fc9
  =
   python(abi) = 2.5
   python-setuptools
   trac

* %check is not present; no test suite upstream.  I have no way to test this
package.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.