[Bug 407581] Review Request: quesoglc - The OpenGL Character Renderer

bugzilla at redhat.com bugzilla at redhat.com
Sun Dec 23 22:12:37 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: quesoglc - The OpenGL Character Renderer


https://bugzilla.redhat.com/show_bug.cgi?id=407581





------- Additional Comments From karlikt at gmail.com  2007-12-23 17:12 EST -------
(In reply to comment #5)
> For 0.6.5-2:
> 
> * GLEW BuildRequires
> (In reply to comment #4)
> > (In reply to comment #1)
> > > * Possibly missing BuildRequires
> > I hope it is fixed :) I removed glew headers from tarball and patch sources.
> 
>   - Still I see the following:
> ---------------------------------------------------------
>    263  checking for GL/glew.h... yes
>    264  checking for glewContextInit in -lGLEW... no
>    265  configure: GLEW will be built and embedded
> ---------------------------------------------------------
>     Is this okay?
yes, this is okay, headers are removed from tarball and in spec are replaced by
symlink to headers from glew-devel
> * Other possibly missing BuildRequires:
>   - From build.log:
> ---------------------------------------------------------
>    600  Preprocessing /builddir/build/BUILD/quesoglc-0.6.5/src/render.c...
>    601  Parsingsh: epstopdf: command not found
>    602  Error: Problems running epstopdf. Check your TeX installation!
> 
>    730  Generating example indexsh: latex: command not found
>    731  Problems running latex. Check your installation or look for typos in
> _formulas.tex and check _formulas.log!
>    732  sh: dvips: command not found
>    733  Problems running dvips. Check your installation!
> ---------------------------------------------------------
>    Perhaps "BuildRequires: tetex-latex" is needed.
I don't need it, only html included so latex can be ignored.
> * Redundant BuildRequires
>   - The following BuildRequires are redundant.
>     libGLU-devel - required by glew-devel, freeglut-devel
>     freetype-devel - required by fontconfig-devel
>     libICE-devel - requried by libSM-devel
removed
> 
> * %check
> > > * %check
> > >   - This tarball contains tests/ directory. If some test programs
> > >     can be executed, please create %check section and execute
> > >     some test programs there.
> > Make runs all tests so I cannot see any sense to run it again in %check
> 
>   - I cannot see this. Doing "make" _creates_ test programs but does not
>     try to actually execute them.
Add
http://karlik.nonlogic.org/quesoglc/quesoglc.spec
http://karlik.nonlogic.org/quesoglc/quesoglc-0.6.5-3.fc8.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list