[Bug 416761] Review Request cppad - A Package for Differentiation of C++ Algorithms

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request cppad - A Package for Differentiation of C++ Algorithms


https://bugzilla.redhat.com/show_bug.cgi?id=416761





------- Additional Comments From bradbell at seanet.com  2007-12-27 09:46 EST -------
(In reply to comment #15)
A new version of 
    http://www.seanet.com/~bradbell/cppad/cppad.spec
has been uploaded. The corresponding rpm source file is
http://www.seanet.com/~bradbell/cppad/cppad-20071225-2.fc7.src.rpm

> For 20071225-1:
> 
> * Requires:
>   - %_includedir/%name/local/test_vector.hpp contains
> ---------------------------------------------------------------
>    101  # if CPPAD_BOOSTVECTOR
>    102  # include <boost/numeric/ublas/vector.hpp>
>    103  # define CPPAD_TEST_VECTOR boost::numeric::ublas::vector
>    104  # endif
> ---------------------------------------------------------------
>     Does this mean that cppad-devel should have
>     "Requires: boost-devel"?

The preprocessor symbol CPPAD_TEST_VECTOR is used to change which template
vector class is used for a large number of the CppAD tests. 

If the option
     --with-stdvector
is included on the CppAD configure command line, the standard vector template
class is used for these tests.

If the option
     BOOST_DIR=BoostDir
is included on the CppAD configure command line, the boost vector class will be
used for these tests (and in this case, boost will need to be installed on the
system to run the tests).


The possible CppAD configure options are documented under the heading Configure
on the web page
     http://www.coin-or.org/CppAD/Doc/installunix.htm
Currently, all of the options, except for the --prefix and --with-Documentation
options, only determine what is tested and in no way change how the final CppAD
installation works. Some of the options require other packages to be installed
because they either test CppAD working with the other packages or compare CppAD
with other packages.

> 
>   - IMO it is bettar that this package has "Requires:
>     libstdc++-devel".

All CppAD requires is a version of C++ that conforms to the language standard;
see ISO/IEC 14882. Does the library mentioned above somehow make up for a
deficiency (lack of support for standard library functions) in some C++ compilers ?

> 
> * Timestamps
>   - As this package installs text files only, keeping timestamps
>     on installed files is highly preferred.
>     As "make install" uses install-sh, perhaps the following method
>     works for keeping timestamps.
> ---------------------------------------------------------------
> %install
> rm -rf $RPM_BUILD_ROOT
> 
> export CPPROG="cp -p"
> make install DESTDIR=$RPM_BUILD_ROOT
> ---------------------------------------------------------------

I am not sure what the timestamps should correspond to. For example, the file
    /usr/include/cppad/cppad.hpp
is over a month old; see
   https://projects.coin-or.org/CppAD/browser/trunk/cppad/cppad.hpp
but its time stamp is December 25 (when the tarball was created).

In addition, there is an extra difficulty for the timestamps of the GPL license
version. The corresponding files are created from the CPL license version by
having sed change the copyright message in each of the source code files
(COIN-OR has been given permission to make this change).


> 
> * Documents
>   - Please add the following document(s) to %doc in -devel.
> ---------------------------------------------------------------
> AUTHORS
> ChangeLog
> ---------------------------------------------------------------
> 
Done. 
In addition, the file uw_copy_040507.html is included because it is referenced
by AUTHORS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.