[Bug 225736] Merge Review: evince

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: evince


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225736


bdpepple at ameritech.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bdpepple at ameritech.net      |krh at redhat.com
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From bdpepple at ameritech.net  2007-02-03 11:20 EST -------
Good:
* Tarball matches upstream
* Source URL is canonical
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* Desktop entry is fine
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* Post scriptlets conforms to packaging guidelines

Minor:
* You could use the disable-static flag with configure and not even bother with
building the static libs.
* Following rpmlint errors, which can be ignored:
W: evince non-conffile-in-etc /etc/gconf/schemas/evince-thumbnailer.schemas
W: evince non-conffile-in-etc /etc/gconf/schemas/evince.schemas

+1 Approve


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.