[Bug 226424] Merge Review: sound-juicer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: sound-juicer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226424


bdpepple at ameritech.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bdpepple at ameritech.net      |alexl at redhat.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From bdpepple at ameritech.net  2007-02-03 12:19 EST -------
Good:
* Tarball matches upstream.
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* All paths begin with macros
* All necessary BuildRequires listed.
* Package builds in Mock.

Must Fix:
* Source URL is not canonical.
* Missing Package URL. http://www.burtonini.com/blog/computers/sound-juicer
* Sound Juicer shouldn't own the following directories (hicolor-icon-theme
should be the sole owner):
/usr/share/icons/hicolor/16x16
/usr/share/icons/hicolor/16x16/apps
/usr/share/icons/hicolor/22x22
/usr/share/icons/hicolor/22x22/apps
/usr/share/icons/hicolor/22x22
/usr/share/icons/hicolor/22x22/apps
/usr/share/icons/hicolor/scalable
/usr/share/icons/hicolor/scalable/apps

Minor:
* Doesn't use the preferred buildroot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Duplicate BuildRequires: GConf2-devel (by gnome-media-devel), gtk2-devel (by
gnome-media-devel), gnome-vfs2-devel (by libgnomeui-devel), glib2-devel (by
libgnomeui-devel), hal-devel (by gnome-vfs2-devel)
* Unnecessary Requires on gstreamer, gtk, libmusicbrainz, and glib2. The BR on
the devel packages should pull these in automatically.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.