[Bug 226035] Merge Review: libogg

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libogg


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226035


bdpepple at ameritech.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |besfahbo at redhat.com
               Flag|                            |fedora-review-




------- Additional Comments From bdpepple at ameritech.net  2007-02-03 13:42 EST -------
Good:

* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* All paths begin with macros
* All necessary BuildRequires listed.
* Package builds in Mock.

Must Fix:
* The devel package require should be:
Requires: libogg = %{epoch}:%{version}-%{release}
* Is the static lib necessary?  If so, it should be split out into a
sub-package.  Refer to:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7

Minor:
* Doesn't use preferred buildroot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Drop the '.' from the summary to quite rpmlint.
* To clean out the install & clean section, you should probably use 'rm -rf
$RPM_BUILD_ROOT' for consistancy
* Does this package build using 'make %{_smp_mflags}'?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.