[Bug 225742] Merge Review: expat

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: expat


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225742


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review-              |fedora-review+




------- Additional Comments From ruben at rubenkerkhof.com  2007-02-04 09:05 EST -------
Hi Joe,

> - %makeinstall is necessary for this non-DESTDIR-aware Makefile

Agreed, from the guidelines:
Fedora's RPM includes a %makeinstall macro but it must NOT be used when make install DESTDIR=%
{buildroot} will work.
So in this case it's not a blocker.

> - dist tag use is not mandatory

That's right

> - explicit BuildRequires is a good thing

True.

> - rpm automatically adds correct Requires for scriptlet interpreters

True as well.

> - yes, static libraries are necessary for the static build of rpm

There's no official policy on the inclusion of static libraries as far as I know, so this is no blocker either.

This package is APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.