[Bug 191036] Review Request: libmp4v2 a library for handling the mp4 container format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmp4v2 a library for handling the mp4 container format


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191036


rpm at greysector.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From rpm at greysector.net  2007-02-04 09:53 EST -------
 1. package meets naming and packaging guidelines.
 2. specfile is properly named, is cleanly written and uses macros consistently.
 3. dist tag is present.
 4. build root is correct, but not the recommended version
    -> please add %(%{__id_u} -n) at the end before importing
 5. license field matches the actual license.
 6. license is open source-compatible (MPL 1.1). License text included in package.

    However, the following file has no license header:
    libmp4v2-1.5.0.1/atom_ohdr.cpp
    Please poke upstream to fix that.

 7. source files match upstream:
    90eb2b0940ebe02ef81b7a60530beaee  libmp4v2-1.5.0.1.tar.bz2
    4b4abb862b079a7e296c891d96faebc9  mklibmp4v2-r51.tar.bz2
 8. latest version is being packaged.
 9. BuildRequires are proper.
10. package builds in mock (fc7/x86_64).
11. rpmlint is silent.
12. final provides and requires are sane:

    libmp4v2 = 1.5.0.1-3.fc7
    =
    /sbin/ldconfig  
    libc.so.6()(64bit)  
    libgcc_s.so.1()(64bit)  
    libm.so.6()(64bit)  
    libmp4v2.so.0()(64bit)  
    libstdc++.so.6()(64bit)  

    libmp4v2-devel = 1.5.0.1-3.fc7
    =
    libmp4v2 = 1.5.0.1-3.fc7
    libmp4v2.so.0()(64bit)  

13. shared libraries are present and ldconfig is called in %post(un).
14. package is not relocatable.
15. owns the directories it creates.
16. doesn't own any directories it shouldn't.
17. no duplicates in %files.
18. file permissions are appropriate.
19. %clean is present.
20. %check is not present, no testsuite.
21. no scriptlets present.
22. code, not content.
23. documentation is small, so no -docs subpackage is necessary.
24. %docs are not necessary for the proper functioning of the package.
25. headers present in -devel package only.
26. no pkgconfig files.
27. no libtool .la droppings.
28. not a GUI app.
29. not a web app.

4. and 6. need work, but are not blockers, so
APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.