[Bug 225290] Merge Review: attr

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: attr


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225290


dan at danny.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|dan at danny.cz                |twoerner at redhat.com
                 CC|                            |dan at danny.cz
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From dan at danny.cz  2007-02-04 10:35 EST -------
OK	source files match upstream:
	    397f565e427e9237537d10345a3b1b09a5f988c4b4035e3bfc1ff5260f20a11d 
attr_2.4.32-1.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	license is open source-compatible. License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (i386).
OK	package installs properly
OK	debuginfo package looks complete.
OK	final provides and requires looks sane.
OK	shared libraries are added to the regular linker search paths, ldconfig is run.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	scriptlets are present and they are sane.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no libtool .la are packaged.
OK	not a GUI app.

MUST FIX:

BAD	headers and .so are in devel subpackage, but the dependency on the lib
subpackage is not correct

SHOULD FIX:

BAD	dist tag is NOT present.
BAD	not suggested build root is used.

BAD	rpmlint is NOT silent.

I: attr checking
W: attr summary-ended-with-dot Utilities for managing filesystem extended
attributes.
W: attr prereq-use /sbin/ldconfig
W: attr prereq-use /sbin/ldconfig
	these are found automagically

W: attr macro-in-%changelog defattr
	macro is not escaped

I: libattr-devel checking
W: libattr-devel no-version-dependency-on libattr 2.4.32
	see MUST FIX
	
W: libattr-devel summary-ended-with-dot Extended attribute static libraries and
headers.
W: libattr-devel symlink-should-be-relative /usr/lib/libattr.so /lib/libattr.so
	could be linked from ../../%{_lib}/libattr.so

I: libattr checking
W: libattr summary-ended-with-dot Dynamic library for extended attribute support.
W: libattr no-documentation

You could also use %doc macro in the %files section instead of %{_datadir}/doc/...


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.