[Bug 226295] Merge Review: php-pear

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: php-pear
Alias: php-pear

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226295





------- Additional Comments From chris.stone at gmail.com  2007-02-05 12:57 EST -------
==== REVIEW CHECKLIST ====
X rpmlint php-pear-1.4.11-3.noarch.rpm:

W: php-pear non-standard-group System

Trivial: change to "Development/Languages"

W: php-pear invalid-license The PHP License v3.0

Trivial: change to "PHP License 3.0"

W: php-pear conffile-without-noreplace-flag /etc/pear.conf
W: php-pear conffile-without-noreplace-flag /etc/rpm/macros.pear

Trivial: Add noreplace flag (or a comment explainging your *good* reason for not
adding a noreplace flag)

W: php-pear hidden-file-or-dir /usr/share/pear/.registry/.channel.__uri
W: php-pear hidden-file-or-dir /usr/share/pear/.registry/.channel.__uri
W: php-pear hidden-file-or-dir /usr/share/pear/.depdblock
E: php-pear zero-length /usr/share/pear/.depdblock
W: php-pear hidden-file-or-dir /usr/share/pear/.depdb
W: php-pear hidden-file-or-dir /usr/share/pear/.lock
E: php-pear zero-length /usr/share/pear/.lock
W: php-pear hidden-file-or-dir /usr/share/pear/.filemap
W: php-pear hidden-file-or-dir /usr/share/pear/.channels
W: php-pear hidden-file-or-dir /usr/share/pear/.channels
W: php-pear hidden-file-or-dir /usr/share/pear/.pkgxml
W: php-pear hidden-file-or-dir /usr/share/pear/.pkgxml
W: php-pear hidden-file-or-dir /usr/share/pear/.registry/.channel.pecl.php.net
W: php-pear hidden-file-or-dir /usr/share/pear/.registry/.channel.pecl.php.net
W: php-pear hidden-file-or-dir /usr/share/pear/.channels/.alias
W: php-pear hidden-file-or-dir /usr/share/pear/.channels/.alias
W: php-pear hidden-file-or-dir /usr/share/pear/.registry
W: php-pear hidden-file-or-dir /usr/share/pear/.registry

Safe to ignore, except for the 0 length ones, do these really need to be in the
package?

$ rpmlint php-pear-1.4.11-3.src.rpm
W: php-pear non-standard-group System

Trivial fix (see above)

W: php-pear invalid-license The PHP License v3.0

Trivial fix (see above)

W: php-pear setup-not-quiet

Trivial:  Add -q to %setup

E: php-pear use-of-RPM_SOURCE_DIR

Never seen this used before, are you using this in place of .?

W: php-pear no-%build-section

Trivial: Add empty build section with a comment saying it is not needed

W: php-pear patch-not-applied Patch1: php-pear-1.4.8-package.patch
W: php-pear patch-not-applied Patch0: php-pear-1.4.8-template.patch

Patches that are not applied should be removed, or commented out with an
explanation as to why there are still there.

- Package named according to package naming guidelines
- spec file name matches %{name}
- package meets packaging guidelines (buildroot fixed)
- licensed with open source compatible license
X license does not match actual license
- license included in %doc
- spec written in American english
- spec file legible
X cannot verify upstream sources match, I cannot find upstream source


==== MUST FIX ====
- Fix trivial rpmlint errors and warnings
- According to http://pear.php.net/package/PEAR this is licensed under the PHP
License 2.02, not 3.0 (please clarify with upstream and/or fix spec)
- SOURCE0 must have full URL to find source files


I have to stop the review here because I cannot find the upstream source file
you use, please provide a full URL to sources!

Indeed, the upgrade to 1.5.0 *is* important as there should be fewer patches in
the spec, and possible build/install changes, and open bugs will be closed.

Please make above mentioned changes and upgrade to 1.5.0 before I continue review.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.