fedora-review granted: [Bug 226478] Merge Review: tar

[bugzilla at redhat.com]

Bug 226478: Merge Review: tar
Product: Fedora Extras
Version: devel
Component: Package Review

Michael Schwendt <bugs.michael at gmx.net> has granted Michael Schwendt
<bugs.michael at gmx.net>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226478

------- Additional Comments from Michael Schwendt <bugs.michael at gmx.net>
* With the better scriptlet dependencies on /sbin/install-info in
place, "Prereq: info" can be deleted:

  $ rpmlint tar-1.15.1-26.src.rpm
  W: tar prereq-use info

* Other releases of tar may need "BuildRequires: gettext" for the
message object files. This version doesn't.

* The changes in cvs look fine.


APPROVED


* A side-note about the binary rpm:

  $ rpmlint tar-1.15.1-26.i386.rpm 
  W: tar file-not-utf8 /usr/share/info/tar.info-1.gz
  W: tar file-not-utf8 /usr/share/info/tar.info.gz

Indeed, in a single line in both files, Jörg Schilling's name is
encoded in ISO 8859-1. That alone would be easy to fix with "iconv",
and a created patch shows no accidental conversions.

However, there are a few 0x0c carriage-return values in those files
(and also in the texinfo input files), which cause these paragraphs,
where the encoding is wrong, to be hidden when displaying the
documentation with "info". I don't know whether the 0x0c are intentional
or supposed to be 0x0a instead.