[Bug 218556] Review Request: ecryptfs-utils - Linux eCryptfs utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ecryptfs-utils - Linux eCryptfs utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218556





------- Additional Comments From kevin at tummy.com  2007-02-07 21:47 EST -------
ok. Understood on the versioning... there are other projects that also
do just iteger releases, for example: xterm (version 223 now).

>Then there is the case where the user builds his kernel without module
>support. I think the approach should be the same as with packages that
>only support specific kernel features, such as CIFS. I looked over the
>SAMBA spec file, and nothing jumped out at me as a kernel module build
>dependency.

Yeah, I don't see anything there either.
I guess just having the 2.6.19 dependency...

>I ran several tests eCryptfs on x86_64 with kernel-2.6.19-1.2895.fc6
>and ext3 as the lower filesystem, and I did not get any errors on
>unmount.

ok. I will retest here...

>In response to comments #17 and #18, I have updated the SPEC file and
>have generated an updated source RPM. Except for an extra comment in
>the README, the source tarball remains unchanged.

>Source RPM:
>
>http://downloads.sourceforge.net/ecryptfs/ecryptfs-utils-9-1.src.rpm
>
>SPEC file:
>
>http://downloads.sourceforge.net/ecryptfs/ecryptfs-utils.spec

Humm. I don't see this addressed:

> 1. Might include the following as %doc files:
> AUTHORS NEWS THANKS

On point 2, you might consider litterally having:
Requires: %{name} = %{version}-%{release}
in the spec. Then you wouldn't need to remember to change the
Requires: ecryptfs = 9-1
on every upgrade.

On point3, I see you have --disable-rpath, so hopefully that fixes the
rpath issues. I will do a build to confirm.

On point4, dist tag looks good.

I am having some mirror issues here, but as soon as thats solved,
I will do another build and do some more testing.
The package is looking pretty good from what I can see...
If you could spin another release addressing the items
above, that would be great.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.