[Bug 227309] Review Request: seom - Desktop video capture and playback utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seom - Desktop video capture and playback utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227309





------- Additional Comments From jwilson at redhat.com  2007-02-08 12:18 EST -------
(In reply to comment #12)
> (In reply to comment #2)
> > * License
> 
> added LICENSE (GPLv2)
> btw, quicklz is licensed under the GPL, so that shouldn't be a problem.

I think we could probably use something along the lines of a README that
includes a bit stating that you're the author of the bulk of the code, with a
reference stating where the codec.c bit came from and that it is also GPL, just
to cover all the bases.

> > 
> > * Timestamps
> 
> No reason to add '-p' when installing seom.pc, because that file is
> auto-generated. But I added '-p' when installing the headers..

Ah, true.

> -$(CC) $(CFLAGS) $(LDFLAGS) -L.libs -o $@ src/$@/main.c -lseom $($@LIBS)
> +$(CC) $(CFLAGS) $(EXTRA_CFLAGS) $(INCLUDES) $(LDFLAGS) -L.libs -o seom-$@
> src/$@/main.c -lseom $($@LIBS)
> 
> 'seom-$@' is ok in the srpm, but when compiling seom from sources more than once
> it's bad because then make will recompile the apps every time make is executed..  

I'll drop that part of my patch.

> and, what's wrong with 'libtool --mode=install'?

For Fedora packages, libtool archives and static libs are forbidden, so it was
solely for the benefit of the package. I'll use a patch that doesn't nuke that,
and will instead remove the file from within the spec.

Other notes on the patch I'm using:
- splitting CFLAGS and EXTRA_CFLAGS makes packaging much easier. Fedora has a
standard set of CFLAGS that are supposed to be used on all packages, so
splitting off the -std=c99 bit into EXTRA_CFLAGS makes life easier, since its
required, but not part of the standard Fedora CFLAGS.
- some of the added $(*DIR) bits are for convenience more than anything, but are
fairly standard.
- you've got lots of extraneous slashes -- $(DESTDIR)/$(PREFIX) works out to
/somewhere//usr -- so I nuke all those.
- I need/want the shared libs, they're greatly preferred over static libs and/or
libtool archives in the Fedora world.


Updated build:

http://people.redhat.com/jwilson/packages/seom/seom-1.0-0.3.161.fc6.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.