[Bug 225656] Merge Review: cpio

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: cpio


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225656


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO




------- Additional Comments From ruben at rubenkerkhof.com  2007-02-08 17:24 EST -------
Hi Peter,

About the timestamps, the line
install -c -p -m 0644 %{SOURCE1} ${RPM_BUILD_ROOT}%{_mandir}/man1
is redundant, make install already does this, so it can be removed.

test -z "/bin" || mkdir -p -- "/var/tmp/cpio-2.6-25.fc6-root-mockbuild/bin"
  /usr/bin/install -c 'cpio' '/var/tmp/cpio-2.6-25.fc6-root-mockbuild/bin/cpio'

So cpio is installed without preserving the timestamp.

And a new rpmlint error:

Source RPM:
W: cpio mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 86)

I've attached a patch with the fixes.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.