[Bug 222521] Review Request: IceWM - Lightweight Window Manager.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: IceWM -  Lightweight Window Manager.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222521


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |pertusus at free.fr
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From pertusus at free.fr  2007-02-10 06:51 EST -------
* rpmlint output is ignorable
W: icewm-gnome no-documentation
W: icewm-xdgmenu no-documentation
* license is LGPL, included 
I thing that you should report upsteram what I say in Comment #21
* source match upstream
 md5sum  icewm-1.2.30.tar.gz icewm-xdg-menu
8a302c5e629bb81d87cc02004a694ece  icewm-1.2.30.tar.gz
85eeefb3335e40fcaed392c61892cc72  icewm-xdg-menu
* %files section is right

APPROVED

Just 2 last suggestions, 
* maybe icewm could own %{_sysconfdir}/icewm but leave it empty.

* in the xdgmenu files section, the icewm-xdg-menu line could be
%{_bindir}/icewm-xdg-menu

Since it is approved you can change that after importing to cvs or keep it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.