[Bug 225244] Merge Review: amtu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: amtu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225244


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|kevin at tummy.com             |sgrubb at redhat.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From kevin at tummy.com  2007-02-11 15:34 EST -------
Sorry for the delay in getting back to this review. 

Everything looks fixed except for 3 items... 

1. On the AMTUHowTo.txt having DOS/win line endings, I guess that fixing that
isn't a blocker. The rpmlint info for that says: "could prevent it from being
displayed correctly in some circumstances." I am unsure what those circumstances
would be. 

2. Forgot to mention that your buildroot is not correct. You should use:
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

3. Not sure what we can do about the upstream source not being somewhere that
can be checked. The package review guidelines have: 
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task.

There does appear to be an upstream source on the sourceforge project, but it's
not the one you are shipping. Have you been able to contact the IBM source to
update that project with the source you are shipping?

Once you have addressed these items (either by making the suggested changes, or
by explaining why they don't make sense), please reassign this review back 
to me, and change the 'fedora-review' flag back to ? for me to take action. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.